On Wed, 5 Aug 2009, Johannes Schindelin wrote: > Hi, > > On Wed, 5 Aug 2009, Daniel Barkalow wrote: > > > On Wed, 5 Aug 2009, Johannes Schindelin wrote: > > > > > Hi, > > > > > > On Wed, 5 Aug 2009, Daniel Barkalow wrote: > > > > > > > This command, supported if the "import" capability is advertized, > > > > allows a helper to support fetching by outputting a git-fast-import > > > > stream. > > > > > > If both the "import" and the "fetch" capability are advertised, the > > > "import" capability is ignored. > > > > The transport code notices that both are supported; it just doesn't use > > the less convenient one. It would be wrong for helpers to advertize both > > and depend on only "fetch" being used. (For example, there's no reason > > that hg couldn't use one of these helpers and use the "import" capability > > despite the "fetch" capability also being advertized, because "import" > > produces results which are portable across local vcses.) > > My point was not to criticize the decision. My point was to criticize the > absence of the comment from both commit message and documentation. But it would be wrong for that documentation to say that "import" is ignored if "fetch" is available, because it's not necessarily true. I'll make the commit message say that git will prefer "fetch". -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html