[RFC/PATCH 1/3] push: add --quiet flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Some transports produce output even without "--verbose"
turned on. This provides a way to tell them to be more
quiet (whereas simply redirecting might lose error
messages).

Signed-off-by: Jeff King <peff@xxxxxxxx>
---
Missing tests and docs still.

It may be a bit weird, but you can actually say "--quiet --verbose" and
they don't exactly cancel each other. But it can actually be useful to
say "don't show me the ref status unless there is an error (--quiet), in
which case show me the entire table (--verbose)".

 builtin-push.c |    1 +
 transport.h    |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/builtin-push.c b/builtin-push.c
index 1d92e22..bc0c91a 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -168,6 +168,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)
 	const char *repo = NULL;	/* default repository */
 
 	struct option options[] = {
+		OPT_BIT('q', "quiet", &flags, "be quiet", TRANSPORT_PUSH_QUIET),
 		OPT_BIT('v', "verbose", &flags, "be verbose", TRANSPORT_PUSH_VERBOSE),
 		OPT_STRING( 0 , "repo", &repo, "repository", "repository"),
 		OPT_BIT( 0 , "all", &flags, "push all refs", TRANSPORT_PUSH_ALL),
diff --git a/transport.h b/transport.h
index 51b5397..f1d3ebf 100644
--- a/transport.h
+++ b/transport.h
@@ -36,6 +36,7 @@ struct transport {
 #define TRANSPORT_PUSH_MIRROR 8
 #define TRANSPORT_PUSH_VERBOSE 16
 #define TRANSPORT_PUSH_PORCELAIN 32
+#define TRANSPORT_PUSH_QUIET 64
 
 /* Returns a transport suitable for the url */
 struct transport *transport_get(struct remote *, const char *);
-- 
1.6.4.218.g9f65c.dirty

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]