Re: [PATCH] Add --allow-eof-whitelines to git-apply while still doing whitespace trailing-space fixing.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Thell Fowler <tbfowler4@xxxxxxxxx>

>   - Added --allow-eof-whitelines to git apply to short-circuit removal
> of new empty lines when tailing-space is set.
>   - Added pass-through to apply from git-am.sh
>   - Added pass-through to git-am from git-rebase.sh
>   - Added the auto-completion entries.
>
> Signed-off-by: TBFowler <thell@xxxxxxxxxxxxxxxxxxx>

I like this new feature. However, this topic came up last week, and Junio said that whitespace checking should be controlled with the attributes mechanism.

http://thread.gmane.org/gmane.comp.version-control.git/124113/focus=124138

Please do not talk "I did this, I did that" in your proposed commit log
message.  From Documentation/SubmittingPatches:

	- the body should provide a meaningful commit message, which:
		- uses the imperative, present tense: "change",
		  not "changed" or "changes".
		- includes motivation for the change, and contrasts
		  its implementation with previous behaviour

In other words, the messages are often written as if you are giving an order to the program to correct itself.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]