On Thu, Sep 21, 2006 at 01:07:54AM +0200, Johannes Schindelin wrote:
> + if (deny_non_fast_forwards && !is_null_sha1(old_sha1)) {
> + struct commit *old_commit, *new_commit;
> + struct commit_list *bases;
> +
> + old_commit = (struct commit *)parse_object(old_sha1);
> + new_commit = (struct commit *)parse_object(new_sha1);
> + for (bases = get_merge_bases(old_commit, new_commit, 1);
> + bases; bases = bases->next)
> + if (!hashcmp(old_sha1, bases->item->object.sha1))
> + break;
> + if (!bases)
> + return error("denying non-fast forward;"
> + " you should pull first");
> + }
Memory leak on 'bases'. It shouldn't matter much because the program is
short-lived, but I couldn't remember if we have a policy on such things
with increasing lib-ification.
-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html