Dear diary, on Thu, Sep 21, 2006 at 01:32:42AM CEST, I got a letter where Junio C Hamano <junkio@xxxxxxx> said that... > Petr Baudis <pasky@xxxxxxx> writes: > > > This patch fixes two things - links to all path elements except the last > > one were broken since gitweb does not like the trailing slash in them, and > > the root tree was not reachable from the subdirectory view. > > > > To compensate for the one more slash in the front, the trailing slash is > > not there anymore. ;-) I don't care if it stays there though. > > Hmph. I see the breakage and behaviour-wise your patch is fine. > > But I think the older one was visually nicer and more intuitive > in one very small detail that I think matters. Slashes between > path components were not part of the anchor elements, so it was > clear that there were two links in "gitweb / gitweb.perl" page > title, not just one link. Now it is not obvious that clicking > different parts of the path string in "/stgit/commands/mail.py" > would lead to different places. And as you are aware, losing > the leading "/" would be nicer as well ;-). Well, this was the best I could come up without introducing "[root] /" or something in front of the path, which would be IMHO even uglier. Alternative ideas welcomed. :-) -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html