Giuseppe Bilotta wrote: > 2009/7/31 Jakub Narebski <jnareb@xxxxxxxxx>: > > I don't think gitweb generates such > > broken links (with 'hash_parent_base' but not 'file_parent') normally, > > but I might be mistaken. > > Do you think it would be worth to protect against this case? Yes, of course it is worth protecting against this case (better checking if both sides of 'eq' comparison are defined). We want to return error message from gitweb if URL is borked, not have Perl error in logs. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html