Re: [PATCHv3 6/8] First draft of notes tree parser with support for fanout subtrees

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 29 Jul 2009, Johan Herland wrote:

> This is a relatively straightforward implementation of parsing notes 
> trees that use fanout directories to limit the size of individual tree 
> objects. This first draft uses a simple linked list for holding unparsed 
> subtree references (to be parsed on demand), and as such, this first 
> draft concentrates more on correctness than performance (AFAICS from 
> t3302, there is no measurable performance impact when no fanout subtrees 
> are present).

I know you want to have something working first and optimize then, but I 
imagined that the hashmap can actually contain the entries of the partial 
hashes, too.  You'll need to extend the data type, of course, to be able 
to say just how many digits of the SHA-1 are valid, and I guess for 
consistency you'll need to pad with 0s.

BTW have you done any performance benchmarks?  If so, how do they look?

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]