On Wed, Jul 29, 2009 at 04:25, Johan Herland<johan@xxxxxxxxxxx> wrote:
> +void get_commit_notes(const struct commit *commit, struct strbuf *sb,
> + const char *output_encoding)
> +{
> + static const char *utf8 = "utf-8";
Using an array
const char utf8[] = "utf-8";
costs you less BSS (no separate storage for the pointer).
> @@ -963,5 +964,9 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
> +
> + if (fmt != CMIT_FMT_ONELINE)
> + get_commit_notes(commit, sb, encoding);
> +
Someday we will need a way to switch off the display of notes
without resolving to oneline format.
Is there a notes specifier for the printf-like log message formatting
(--pretty=format: or --format) planned, BTW?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html