Re: Add option in git-am to ignore leading text?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 28 July 2009, Nicolas Sebrecht wrote:
> The 28/07/09, Frans Pop wrote:
> > That's a very useful feature. However, on lkml there are frequently
> > also mails with the following structure (example: [1]).
> >
> > [1] http://lkml.org/lkml/2009/7/10/49
>
> This is an example of what not to do. Content after the '---' won't be
> part of the commit message.

Yes, I'm aware of that (and I omitted such a line from my example for that 
reason). But currently that's not really relevant as either with or 
without that line one needs to manually fix up things before the desired 
result is obtained.

If my feature request is implemented I'll of course make sure to omit the
'---' line if needed.

Here are some other examples (some of which would equally need to drop or 
change a separator line).
http://lkml.org/lkml/2009/6/25/62
http://lkml.org/lkml/2009/6/22/114
http://lkml.org/lkml/2009/6/30/109
http://lkml.org/lkml/2009/6/30/224

> IMHO, a better way would be to ignore lines beginning with a defined
> level of quotes in the commit message (the "level" beeing the number of
> '>' or '> ' found at the beginning of a line. Something like
>
> 	--strip-quotes[=N]
>
> where N is the level of quoted lines to remove (if "=N" is
> not given, assume that the level is 1 and remove all the quotes).

As Mark Brown has already said, that won't solve the issue for an 
introduction or comments added by the sender of the mail.
Also, people use all kinds of quoting schemes, not just leading ">".

And I've also seen plenty of cases where quoted lines _were_ a desired 
part of a commit log.

Thanks,
FJP
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]