Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: > > > Instead of trying to read info/refs file, which might not be present > > (we did fallback to git-ls-remote), always use git-peek-remote in > > git_get_references. > > > > It is preparation for git_get_refs_info to also return references > > info. We cannot use info/refs for git_get_refs_info as the information > > contained therein is usually stale. > > What the patch does is sane, but I think the last sentence of > the proposed log message is not. If info/refs is "usually > stale", it is a bug in the repository to have such a stale file. > > The real reason for this patch is that a repository served by > gitweb is not necessarily meant to be fetched over HTTP and > info/refs does not have to be there. If the repository served by gitweb is updated using push, then info/refs updated using post-update hook is up-to-date. If repository is "live" repository, updated also using commit, rebase and such, info/refs is usually stale. If there were post-commit hook, and it's contents was the default post-update hook, info/refs would be never stale. And we could read from into/refs, and fallback to git-peek-remote if it doesn't exist... but we don't know if info/refs has current info. -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html