On Tue, Jul 28, 2009 at 11:27 AM, Thomas Rast<trast@xxxxxxxxxxxxxxx> wrote: > Erik Faye-Lund wrote: >> On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@xxxxxxxxx> wrote: >> > I assume that this is a configuration issue in the git setup of the >> > sender, but shouldn't git-send-email refuse to send out messages with an >> > invalid Message-Id? >> >> Not quite. git-send-email generates these message-ids itself (those >> who contain "-git-send-email-", that is), and should as such be able >> to rely on them being generated correctly. [...] >> I'm no perl-expert, but the code looks pretty much correct to me. > > git-format-patch generates its own message IDs if it needs them for > threading, with gen_message_id() (in builtin-log.c). That one appends > the committer email address blindly, without verifying that it has an > @ in it. That must be a separate issue (but quite possibly a valid one), since gen_message_id's ids dont' contain "-send-email-" like the message-id in the report does, no? -- Erik "kusma" Faye-Lund kusmabite@xxxxxxxxx (+47) 986 59 656 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html