Re: git format-patch from date never set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Savilonis <djs@xxxxxxxxxx> writes:

> On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen<raa.lkml@xxxxxxxxx> wrote:
>> Neither. This is not a date, but a part of "loosely defined" mbox format.
>>
>
> In the examples of mbox format I have found, the date in the From:
> line is generally the same as in the Date: line, albeit in a more
> ambiguous format. Further, the the git code treats it as a date and
> attempts to set it. It remains at the default date only because
> git_committer_info() is called without GIT_COMMITTER_DATE set.
>
> So is the code misleading? Was it designed to just meet the minimal
> requirement of having a date-like string to comform to the mbox
> format? What's the disadvantage to using the real commit date?

Having it as a fixed date-looking string was to help /etc/magic entry
people may want to invent to detect format-patch output.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]