Re: [PATCH] git init: optionally allow a directory argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jul 24, 2009, at 4:36 PM, Junio C Hamano wrote:

Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes:

When starting a new repository, I see my students often say

   % git init newrepo

and curse git.  They could say

   % mkdir newrepo; cd newrepo; git init

but allowing it as an obvious short-cut may be nicer.

Signed-off-by: Nanako Shiraishi <nanako3@xxxxxxxxxxx>

Hmm, I didn't realize this is so common a wish among new people.

The patch seems clean.  Anybody has comments, both on code and the use
case?

The use case makes sense. This helps make git init be a bit more consistent
with git clone, which can take a trailing target.

For the code, I would replace the direct use of mkdir with safe_create_dir.
Otherwise it looks fine.

-Alex Scarborough

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]