Re: [PATCH 2/2] git repack: keep commits hidden by a graft

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 23 Jul 2009, Junio C Hamano wrote:

> It would probably make more sense to call it "--keep-real-parents" or 
> something.

Much better.

> Do we want to cull duplicated parents?  I do not think it matters in 
> this particular context of checking the reachability, but I am just 
> double checking if you thought about the issue.

I thought about it, and decided it is not worth the hassle: originally I 
had the option in setup_revisions() until I realized that this is never 
called by pack-objects.  So how about this addition to the commit message:

	As this behavior can only be triggered by git pack-objects, and as 
	that command handles duplicate parents gracefully, we do not 
	bother to cull such parents.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]