Re: [PATCH v4] grep: Add --max-depth option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This looks good now. Just one minor point but I don't think it requires
a resend.

Michał Kiedrowicz wrote:
>
> +		{ OPTION_INTEGER, 0, "max-depth", &opt.max_depth, "depth",
> +			"descend at most <depth> levels", PARSE_OPT_NONEG,
> +			NULL, 1 },

This NULL and 1 are not needed unless you're using PARSE_OPT_OPTARG. I
think this last line can be safely removed.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]