Thanks for a review. With the suggested changes the patch looks better. I had to wonder what would happen when you give an input like this, though: $ git grep --max-depth=1 t Documentation/howto If you look at the way the loop in pathspec_matches() is structured, it becomes clear that the depth limit is applied independently to each of the pathspecs given on the command line, and re-reading the description of the option in the documentation _with_ that knowledge it becomes obvious what should happen, but I couldn't figure it out before looking at the code. Perhaps the documentation needs a bit more verbosity? I dunno. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html