måndag 13 juli 2009 16:53:08 skrev "Shawn O. Pearce" <spearce@xxxxxxxxxxx>: > Yann Simon <yann.simon.fr@xxxxxxxxx> wrote: > > This method is quite clear. > > One line javadoc would make it even clearer... :p (and maybe make Robin happy) > > Javadoc is overrated. Private utility methods like this that are one > line long don't need documentation. The rationale for why this line > does what it does is something that `git blame` can answer better. Sorry Yann, I'm with Shawn here. A comment wouldn't add anything here since the method is pretty simple. Besides javadocs are for API's so an inline comment would be better, but I don't think it is necessary. Shawn, any references for the ability of JIT's abilities to stack allocate in this context? For me learning, will commit anyway. -- robina -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html