Re: [PATCH 2/3] push: add --current

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/20/2009 12:15 PM, Tay Ray Chuan wrote:
Hi,

On Mon, Jul 20, 2009 at 2:36 PM, Paolo Bonzini<bonzini@xxxxxxx>  wrote:
  t/t5516-fetch-push.sh      |   50 ++++++++++++++++++++++++++++++++++++++++++++

since you're making modifications to pushing over HTTP, you should
consider making tests also for HTTP repositories, or else your changes
in http-push.c won't be used.

Yeah, I had tested them with a server I already had setup rather than with the testsuite, because the default Apache setup of Fedora is not detected correctly by lib-httpd.sh. Any test I included would then be untested, while http-push.c was tested. :-)

However, I'll include the tests in v3 of the patch.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]