When showing an annotated tag, "git show" will always
display the pointed-to object. However, it didn't separate
the two with whitespace, making it more difficult to notice
where the new object started. For example:
$ git tag -m 'my message' foo
$ git show foo
tag foo
Tagger: Jeff King <peff@xxxxxxxx>
Date: Fri Jul 17 18:46:25 2009 -0400
my message
commit 41cabf8fed2694ba33e01d64f9094f2fc5e5805a
Author: Jeff King <peff@xxxxxxxx>
Date: Thu Jul 16 17:31:34 2009 -0400
...
This patch adds a blank line between "my message" and
"commit 41c...", making it easier to read.
Signed-off-by: Jeff King <peff@xxxxxxxx>
---
I was tempted to add logic for "put a blank line separator between each
two items printed by git show", instead of just tags. But:
- commits already do that (e.g., "git show HEAD HEAD^" looks fine)
- blobs don't do it, but you probably don't want them to. I don't know
why you would really do "git show HEAD:foo HEAD:bar", but you could,
and I would expect it to concatenate them without extra data.
Trees don't do it, so if you "git show HEAD^{tree} HEAD^{tree}" there is
no separator. Maybe that is worth fixing separately, but I find it
unlikely for somebody to do that. Annotated tags are the much more
common case, because you always get two objects displayed.
builtin-log.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index b05796d..d3e4d1a 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -342,6 +342,7 @@ int cmd_show(int argc, const char **argv, const char *prefix)
sha1_to_hex(t->tagged->sha1));
objects[i].item = o;
i--;
+ putchar('\n');
break;
}
case OBJ_TREE:
--
1.6.4.rc1.174.g317bf.dirty
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html