On Wed, Jul 15, 2009 at 12:27:05AM -0700, Junio C Hamano wrote: > Nicolas Sebrecht <nicolas.s.dev@xxxxxx> writes: > > > Patch format detection introduced by a5a6755a1d4707bf2fab7752e5c974ebf63d086a > > may refuse valid patches from verbatim emails. > > It is unclear what you meant by "verbatim email". A verbatim e-mail > in mbox begins with "From " header that is already covered in the existing > code long before support for stgit/hg was added. I believe he is referring to the claimed support for maildir format boxes. > But I am not convinced that I understand what _problem_ you are trying to > solve in the first place. Assuming it is maildir support, then there is no 'header' as such in the file which can be detected. One could try and detect that the contents are structured as an RFC822 message (but with local line ends), or one could try and detect that the file is within a maildir folder. It seems this patch is taking the former approach and trying to ensure the file consists of header fields. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html