On Tue, 14 Jul 2009, Junio C Hamano wrote:
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:
>
> > Quite frankly, I'd like for us to at least think about removing CE_VALID.
>
> This is heavy. I personally do not use this flag, nor know anybody who
> does, but deviating from the original purpose of CE_VALID, which was to
> avoid lstat() on slow filesystems, people have advised/advocated its use
> for "narrow checkout".
Ahh. I kind of was aware of that, but had totally forgotten.
And in that case, I guess it's also fine. In fact, for that case CE_VALID
would tend to really mean "always assume CE_UPTODATE", so then the patch I
sent out doesn't really necessarily need the whole "known_uptodate()"
thing, and could just use
if (o->reset && !ce_valid(old)) {
instead.
Which also makes my other worries go away.
Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html