On Fri, Sep 15, 2006 at 11:19:02PM -0700, Junio C Hamano wrote: > Junio C Hamano <junkio@xxxxxxx> writes: > > Gerrit Pape <pape@xxxxxxxxxxx> writes: > >> sh t3403-rebase-skip.sh </dev/null fails because stdin is not connected > >> to a terminal, as in the Debian autobuild environment. This disbales > >> the test 3 and 7 in this case. > > > > Disabling these tests somehow feels as if you are shooting the > > messenger who reports breakage of the commands they try to test. > > > > Is it expected that the git Porcelainish commands involved in > > these particular tests not to work without terminal? If not > > maybe we should fix them, not the test. > > How about this instead? Yes, this is the better fix, I agree. The selftests work fine for me with this patch applied. Thanks, Gerrit. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html