On Sat, 11 July 2009, Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: > > > Luben Tuikov changed 'lineno' link (line number link) from pointing to > > 'blame' view at given line at blamed commit, to the one at parent of > > blamed commit in > > 244a70e (Blame "linenr" link jumps to previous state at > > "orig_lineno", 2007-01-04). > > This made it possible to do data mining using 'blame' view, by going > > through history of a line using mentioned line number link. > > I was playing with this feature the other day (and I think you can guess > what I was writing when I was doing so as preparation). I was mildly > annoyed that these links on the commit object names go to the commit view. > > I think going to commitdiff view would make it far more useful while > digging. [...] Also with a slight extension of diff part of 'commitdiff', by adding line numbers for preimage in chunk and line numbers for postimage in chunk, like e.g. in 'commit' view on GitHub[1] or on Gitorious[2] or in SVN::Web[3] or in Atlassian FishEye, and adding anchors for those line numbers we could go to given line in dif/patch output and examine how it looked like before. [1] http://github.com/jnareb/softsnow-xchat2-filter/commit/7b68fcd777f94534f0b794c5dc2e109c49938395 [2] http://gitorious.org/softsnow-xchat2-filter/mainline/commit/7b68fcd777f94534f0b794c5dc2e109c49938395 [3] http://jc.ngo.org.uk/svnweb/jc/diff/nik/CPAN/SVN-Web/trunk/README?revs=1283&revs=981 (This would probably require adding 'fmt' / 'format' parameter, where one could choose between possible ways to view diff, or possible ways to view log or log-like view.) P.S. BTW. 'blame' view passes _original_ filename (not filename at blamed commit) to 'commit' view link... but it doesn't matter because 'commit' view does not use 'f'/$file_name parameter. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html