Johan Herland <johan@xxxxxxxxxxx> writes: > quickfetch() calls rev-list to check whether the objects we are about to > fetch are already present in the repo (if so, we can skip the object fetch). > However, when there are many (~1000) refs to be fetched, the rev-list > command line grows larger than the maximum command line size on some systems > (32K in Windows). This causes rev-list to fail, making quickfetch() return > non-zero, which unnecessarily triggers the transport machinery. This somehow > causes fetch to fail with an exit code. > > By using the --stdin option to rev-list (and feeding the object list to its > standard input), we prevent the overflow of the rev-list command line, > which causes quickfetch(), and subsequently the overall fetch, to succeed. I feel uneasy with that "somehow" at the end of the first paragraph, but nevertheless this is the right thing to do. Since it is a very isolated change, I'd queue this directly on 'master' and see if anybody notices a breakage, as it would be relatively pain-free to revert if it turns out to be necessary. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html