Re: [PATCH 7/3] Make index preloading check the whole path to the file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 7/3] Make index preloading check the whole path to the file
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 9 Jul 2009 20:29:05 -0700 (PDT)
Cc: Dmitry Potapov <dpotapov@xxxxxxxxx>, Git Mailing List <git@xxxxxxxxxxxxxxx>, Kjetil Barvik <barvik@xxxxxxxxxxxx>
In-reply-to: <7v8wixw7s0.fsf@xxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.01 (LFD 1184 2008-12-16)


On Thu, 9 Jul 2009, Junio C Hamano wrote:
> 
> I must be missing something very obvious, but how would this call behave
> on an uninitialized cache defined above, or do we need reset_lstat_cache()
> on it before the first use?

Neither.

It should be memset() to zero. Good catch.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH 7/3] Make index preloading check the whole path to the file
  - From: Junio C Hamano
- Re: [PATCH 7/3] Make index preloading check the whole path to the file
  - From: Linus Torvalds

References:
- Too many 'stat' calls by git-status on Windows
  - From: Dmitry Potapov
- Re: Too many 'stat' calls by git-status on Windows
  - From: Linus Torvalds
- [PATCH 1/3] Add 'fill_directory()' helper function for directory traversal
  - From: Linus Torvalds
- [PATCH 2/3] Simplify read_directory[_recursive]() arguments
  - From: Linus Torvalds
- [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Linus Torvalds
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Junio C Hamano
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Linus Torvalds
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Junio C Hamano
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Linus Torvalds
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Linus Torvalds
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Junio C Hamano
- Re: [PATCH 3/3] Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
  - From: Linus Torvalds
- [PATCH 4/3] Avoid using 'lstat()' to figure out directories
  - From: Linus Torvalds
- [PATCH 5/3] Prepare symlink caching for thread-safety
  - From: Linus Torvalds
- [PATCH 6/3] Export thread-safe version of 'has_symlink_leading_path()'
  - From: Linus Torvalds
- [PATCH 7/3] Make index preloading check the whole path to the file
  - From: Linus Torvalds
- Re: [PATCH 7/3] Make index preloading check the whole path to the file
  - From: Junio C Hamano

Prev by Date: Re: [PATCH 7/3] Make index preloading check the whole path to the file
Next by Date: Re: git-svn is "Unable to determine upstream SVN information..."
Previous by thread: Re: [PATCH 7/3] Make index preloading check the whole path to the file
Next by thread: Re: [PATCH 7/3] Make index preloading check the whole path to the file
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]