Johan Herland schrieb: > On Thursday 09 July 2009, Johannes Sixt wrote: >> But actually I meant you to make a test that triggers the SIGPIPE that >> would kill git-fetch if it were not ignored. This one doesn't trigger it, >> either. > > AFAIU from earlier in this thread (and a mail from Peter linking to > http://markmail.org/message/dbgdj4csafen65ye), SIGPIPE _never_ triggers on > Windows, thus ignoring SIGPIPE is not needed for the fix per se. However, as > a side-effect of the fix, we may now get SIGPIPE on Linux (and other POSIX > platforms), so although it never triggers on Windows, it's still needed. I know that, of course. But try this: Remove the signal(SIGPIPE, SIG_IGN) and run the test suite. There is not a single failure. IOW, we don't have a single test case that verifies that the signal(SIGPIPE, SIG_IGN) is needed. I would like to have that test case, and you seem to know how to construct it (otherwise there wouldn't be so much buzz about it). -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html