"Art Haas" <ahaas@xxxxxxxxxxx> writes: > Older curl releases do not define CURLE_HTTP_RETURNED_ERROR, they > use CURLE_HTTP_NOT_FOUND instead. The trivial patch below fixes > the build error. Newer curl releases keep the CURLE_HTTP_NOT_FOUND > definition but using a -DCURL_NO_OLDIES preprocessor flag > the old name will not be present in the 'curl.h' header. The > comments in 'curl.h' have more info about the name change. > > Signed-off-by: Art Haas <ahaas@xxxxxxxxxxx> The patch to use older name in a recent program feels going backwards. The header is only trying to be nice so you can compile old programs written for older interface that use older names. If the new way is the primary way with the new interface, and if we are writing a new program, I think we should write for the new interface. Can we have the main code to target the more recent version, while working around problems with older versions with backward compatibility macros? In other words, if the macro HTTP_RETURNED_ERROR is not defined in the header (i.e. older version), you define it to be the same as HTTP_NOT_FOUND. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html