On Tue, Jun 30, 2009 at 11:28:26AM -0700, Junio C Hamano wrote: > Looking at ff06c74 (Improve request-pull to handle non-rebased branches, > 2007-05-01), it introduced these specifically to address the issue you are > bringing up, but it is ineffective. > > I'd suggest to replace your patch with the attached instead. > > --- > > git-request-pull.sh | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/git-request-pull.sh b/git-request-pull.sh > index a2cf5b8..f86d8fd 100755 > --- a/git-request-pull.sh > +++ b/git-request-pull.sh > @@ -42,8 +42,8 @@ if [ -z "$branch" ]; then > status=1 > fi > > -PAGER= > -export PAGER > +GIT_PAGER=cat > +export GIT_PAGER Good idea, but for completeness, it should be set before this command: git log --max-count=1 --pretty='format:warn: %h: %s' $headrev >&2 (which should use tformat to get the newline right). So what about this one? --- diff --git a/git-request-pull.sh b/git-request-pull.sh index ab2dd10..5917773 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -12,6 +12,9 @@ OPTIONS_SPEC= . git-sh-setup . git-parse-remote +GIT_PAGER= +export GIT_PAGER + base=$1 url=$2 head=${3-HEAD} @@ -34,7 +37,7 @@ branch=$(git ls-remote "$url" \ }") if [ -z "$branch" ]; then echo "warn: No branch of $url is at:" >&2 - git log --max-count=1 --pretty='format:warn: %h: %s' $headrev >&2 + git log --max-count=1 --pretty='tformat:warn: %h: %s' $headrev >&2 echo "warn: Are you sure you pushed $head there?" >&2 echo >&2 echo >&2 @@ -42,8 +45,6 @@ if [ -z "$branch" ]; then status=1 fi -GIT_PAGER= -export GIT_PAGER echo "The following changes since commit $baserev:" git shortlog --max-count=1 $baserev | sed -e 's/^\(.\)/ \1/' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html