Matthias Lederhofer <matled@xxxxxxx> writes:
> Currently it is possible to give any string ending with a number as
> page. -1 for example is quite bad (error log shows probably 100
> warnings).
>
> @@ -259,7 +259,7 @@ if (defined $hash_parent_base) {
>
> our $page = $cgi->param('pg');
> if (defined $page) {
> - if ($page =~ m/[^0-9]$/) {
> + if ($page =~ m/[^0-9]/) {
> die_error(undef, "Invalid page parameter");
> }
> }
Are we complaining if $page is not a validly formatted number
here? If so why not
unless ($page =~ /^\d+$/ && 1 <= $page) {
barf(...);
}
???
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html