Re: [PATCHv7 4/9] gitweb: right-align date cell in shortlog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/6/27 Jakub Narebski <jnareb@xxxxxxxxx>:
> On Sat, 27 June 2009, Giuseppe Bilotta wrote:
>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
>
> I don't like it.  In my opinion it is less readable that way, especially
> if word wrapping gets involved:
>
>  5 hours |
>      ago |
>
>  5 hours |
>      ago |
>
>   5 days |
>      ago |
>
> It is IMVHO a bit ugly.

You might have a point there.

> That aside this is *not complete*.  Take a look at 'summary' view.
> You have there 'date' column in 'shortlog' section aligned to the right,
> while in 'heads' and 'tags' section it is aligned to the left.  Add to
> that "Last Change" column in projects list view (which should probably
> be aligned to the left, even with this patch completed).
>
> NAK from me.  (Alternate stylesheet?  Just kidding...)

[...]
>
> On the other hand: it is short and simple.

And totally independent from the rest of the patchset. I'll move it to
the top of the stack, so that the rest of the next iteration can be
applied in batch as soon as it's ready.

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]