Re: [PATCHv7 2/9] gitweb: uniform author info for commit and commitdiff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> I would use:
>
>   Switch from form similar to the one used by 'log' view
>
>   	A U Thor <email@xxxxxxxxxxx> [date time]
>
>   to the form used in 'commit' view
>
> 	author       A U Thor <email@xxxxxxxxxxx>
>   	 	     date time
>   	committer    C O Mitter <other.email@xxxxxxxxxxx>
>   	             date time
>
> (i.e. use spaces and not tabs to align).  But this is minor
> issue, not worth worrying about IMVHO.

These extra blank lines make things much easier to read, and explicit
mention of switching from WHAT to WHAT ELSE is very much appreciated.

> On the other hand side IIRC 'commitdiff' uses short (one-line) 
> authorship info because the main point is the diff, and multi-line
> author and commit info like the one used in 'commit' view takes
> a bit of vertical space.

In general, we might want to make the committer information less prominent
than it currently is.

When looking at a repository that is used like CVS, author and committer
are always the same.  When looking at a repository that is owned by a
single integrator, the committer is a single person.  The only time
committer information for every commit would help is when viewing a
repository of higher level integrator in a project that has subintegrators
(e.g. Linus pulls from David who commits patches from others).

So at some point, it may not be a bad idea to introduce a per-repository
option/feature to hide committer information from certain views to
allocate more space for other information.

But certainly that shouldn't be a part of this topic.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]