Re: [PATCH] git-remote: fixed missing .uploadpack usage for show command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Frey <cdfrey@xxxxxxxxxxxxxx> writes:

> When using 'git remote show <name>', the remote HEAD check
> did not use the uploadpack configuration setting.
>
> Signed-off-by: Chris Frey <cdfrey@xxxxxxxxxxxxxx>

Thanks.

"X did not use Y" may be a good statement of the fact.  From the patch
text it can be seen that a NULL used to be passed and the patch makes it
to pass states->remote instead, so "This patch make X use Y", even though
left unsaid in the message, can be seen.

But it does not answer a more important question.  How was it a problem
that "X did not use Y"?

People who followed a recent discussion know the answer to this question,
but ones who read this in the "git log" output 6 months down the line will
not.  Please make a habit of justifying the change by stating "why".

"X should have used Y because of such and such reasons, but it didn't.
Instead of showing the correct result W, it gave Z, which may happen to be
the same as W in default settings but otherwise is wrong."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]