René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > the following patch is for git. I just removed the unneeded check for > res == 0 from your version. Does it look OK? The patch looks good, and both of our in-tree users do error out when the returned value is 0 (imap-send.c checks with "<= 0" which looks a tad amateurish, though) correctly. Funny, there is no caller of this function in the original context this bug originally found, which I think is linux-2.6/tools/perf ;-). Thanks. > From: Roel Kluin <roel.kluin@xxxxxxxxx> > > size_t res cannot be less than 0. fread returns 0 on error. > > Reported-by: Ingo Molnar <mingo@xxxxxxx> > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > strbuf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/strbuf.c b/strbuf.c > index a884960..f03d117 100644 > --- a/strbuf.c > +++ b/strbuf.c > @@ -260,7 +260,7 @@ size_t strbuf_fread(struct strbuf *sb, size_t size, FILE *f) > res = fread(sb->buf + sb->len, 1, size, f); > if (res > 0) > strbuf_setlen(sb, sb->len + res); > - else if (res < 0 && oldalloc == 0) > + else if (oldalloc == 0) > strbuf_release(sb); > return res; > } -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html