Re: [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 21, 2009 at 12:17 AM, Johannes Sixt<j6t@xxxxxxxx> wrote:
> On Samstag, 20. Juni 2009, newren@xxxxxxxxx wrote:
>> -test_expect_success 'tree_tag'        'git fast-export tree_tag'
>> +test_expect_success 'tree_tag'        '
>> +     mkdir result &&
>> +     cd result &&
>> +     git init &&
>> +     cd ..
>> +     git fast-export tree_tag | (cd result && git fast-import)
>> +'
>
> You should make this
>
> test_expect_success 'tree_tag' '
>        mkdir result &&
>        (cd result && git init) &&
>        git fast-export tree_tag > fe-stream &&
>        (cd result && git fast-import < fe-stream)
> '
>
> in order to (1) not remain in the wrong directory if git init fails, and (2)
> to catch failures in git fast-export.

Thanks for the tips; I've sent a new patch series with these changes
(except that the second fe-stream needs a ../ in front of it), as well
as the changes suggested by Stephen Boyd in the other email in this
thread.

Elijah
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]