I've done the refactoring in a separate patch, to have a better (IMO) view of what I was doing. I can squash them together if needed. There have also been a couple of other changes such as the use of 'require' instead of 'use' to access Digest::MD5, and a better call pattern for git_get_gravatar. One thing that is missing but could be done is an email -> MD5 hash mapping to cache multiple occurences of the same email (not unusual in (short)log view). Giuseppe Bilotta (2): gitweb: gravatar support gitweb: refactor author+gravatar insertion gitweb/gitweb.css | 9 +++++- gitweb/gitweb.perl | 83 ++++++++++++++++++++++++++++++++++++++++++--------- 2 files changed, 76 insertions(+), 16 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html