On Sat, 20 Jun 2009, Junio C Hamano wrote: > Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > > > This is better than saving in a shell script, because it will make > > it much easier to port "rebase -i" to C. > > Hmph. > > We used to parse a commit object in one go into variables, and I would > have imagined that a rewrite in C will read a commit object to get the > author information in variables in-core, without having to write any > temporary file. > > But with your patch, it starts to use a temporary file, and forces the C > rewrite to do the same. It closes the door for a more efficient rewrite. > > Why is this a good change? It was always using a temporary file; it just used to use a temporary file that was a shell script fragment and needed to be read with "eval". It can't be done entirely in core because it may be determined before a conflict and only used when run with --continue after the user resolves the conflict. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html