Junio C Hamano <gitster@xxxxxxxxx> writes: > ... > If the convention is "GIT_QUIET, when set to non-empty string, squelches > the output", then I think the callers should be more consistent and the > call to prune-packed should say something like this, which is admittedly a > roundabout way: > > git prune-packed ${GIT_QUIET:+-q} > > for consistency (and then what you set to GIT_QUIET in the first hunk I > quoted does not matter anymore---it can even be t or 1 or whatever). > > I think this does not matter too much, because I suspect that in the > longer term scripted Porcelains are going away, but still... What I meant was that my _style_ comment does not matter too much. The addition of "quiet" _is_ a worthwhile thing to do, I think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html