2009/6/15 Stephen Boyd <bebarino@xxxxxxxxx>: > Scripts should use say() when they want to echo to stdout. Setting > GIT_QUIET will mute say(), allowing scripts to easily implement a quiet > option. > > Signed-off-by: Stephen Boyd <bebarino@xxxxxxxxx> > --- > git-sh-setup.sh | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/git-sh-setup.sh b/git-sh-setup.sh > index 80acb7d..f88184e 100755 > --- a/git-sh-setup.sh > +++ b/git-sh-setup.sh > @@ -44,6 +44,13 @@ die() { > exit 1 > } > > +say () { > + if test -z "$GIT_QUIET" > + then > + echo "$@" Except that where you've then replaced various calls with say() they were originally using printf. Please use printf here also, and not echo. -- Thomas Adam -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html