Gerrit Pape <pape@xxxxxxxxxxx> writes: > Patch from Cyril Brulebois to make the build process detect and support the > Debian GNU/Hurd architecture, see > http://bugs.debian.org/379841 > > Signed-off-by: Gerrit Pape <pape@xxxxxxxxxxx> > > +ifeq ($(uname_S),GNU) > + # GNU stands for GNU/Hurd > + NO_STRLCPY = YesPlease > + ALL_CFLAGS += -DPATH_MAX=4096 > +endif Two questions come to mind. (1) Does GNU stand for GNU/Hurd and nobody else? (2) Does everybody else have PATH_MAX? Adding NO_STRLCPY I do not have much problems with, but something like the attached may be cleaner to deal with PATH_MAX; of course now there is an issue of what the appropriate value for that symbol should be. Would including git-compat-util.h in builtin.h break somebody? -- >8 -- Define fallback PATH_MAX on systems that do not define one in <limits.h> Notably GNU/Hurd, as reported by Gerrit Pape. Signed-off-by: Junio C Hamano <junkio@xxxxxxx> --- diff --git a/git-compat-util.h b/git-compat-util.h index 552b8ec..0272d04 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -26,6 +26,13 @@ #include <netinet/in.h> #include <sys/types.h> #include <dirent.h> +/* On most systems <limits.h> would have given us this, but + * not on some systems (e.g. GNU/Hurd). + */ +#ifndef PATH_MAX +#define PATH_MAX 4096 +#endif + #ifdef __GNUC__ #define NORETURN __attribute__((__noreturn__)) #else diff --git a/builtin.h b/builtin.h index 34ed7b9..1d41f83 100644 --- a/builtin.h +++ b/builtin.h @@ -1,8 +1,7 @@ #ifndef BUILTIN_H #define BUILTIN_H -#include <stdio.h> -#include <limits.h> +#include "git-compat-util.h" extern const char git_version_string[]; extern const char git_usage_string[]; - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html