2009/6/8 Johannes Schindelin <Johannes.Schindelin@xxxxxx>: > On Mon, 8 Jun 2009, Alex Riesen wrote: >> NOT TESTED. Can't. My Windows broke again. Not even compile-tested. > > Yes, that is pretty easy to see as you first used pold/pnew and then > src/dst. Yep. > I minimally fixed up your patch (it now uses strbuf), and added a > test-case. > > This test-case is actually crucial: it shows that your patch is not > enough: the culprit is this code in builtin-mv.c:167--168: > > else if (lstat(dst, &st) == 0) { > bad = "destination exists"; Ah, thanks. Missed that completely. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html