Marco Nelissen <marcone@xxxxxxxxx> writes:
> diff --git a/configure.ac b/configure.ac
> index 108a97f..3388036 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -385,6 +385,8 @@ AC_SUBST(NO_EXPAT)
> # some Solaris installations).
> # Define NO_ICONV if neither libc nor libiconv support iconv.
>
> +if test -z $NO_ICONV; then
> +
> GIT_STASH_FLAGS($ICONVDIR)
>
> AC_DEFUN([ICONVTEST_SRC], [
> @@ -431,6 +433,12 @@ GIT_UNSTASH_FLAGS($ICONVDIR)
> AC_SUBST(NEEDS_LIBICONV)
> AC_SUBST(NO_ICONV)
>
> +if test -n $NO_ICONV; then
> + NEEDS_LIBICONV=
> +fi
> +
> +fi
> +
Hmm, have you tested this with both NO_ICONV defined and undefined?
Because ...
$ test -z ; echo $?
0
$ test -n ; echo $?
0
... I would feel better if you had dq around $NO_ICONV in both tests.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html