måndag 08 juni 2009 00:21:54 skrev "Shawn O. Pearce" <spearce@xxxxxxxxxxx>: > Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote: ... > > + int p1 = RawParseUtils.next(raw, p0 + 1, ':'); > > + if (p1 == -1) > > + throw new IllegalArgumentException( > > + "Raw log message does not parse as log entry"); > > Technically, missing a ':' is legal. Everything after the '\t' > is the comment. It may be splittable into an action/comment, > it might not be. Do you think I should just skip parsing out action? I don't really need it. I can go with everything after tab as one string for my purposes, i.e. reading reflogs in JUnit tests. As for optimized reading, I'd rather spend my time on something else. Reading reflogs won't likely be a real problem and I think the interface will be stable even if it needs to be optimized. The other stuff I'll fix. -- robin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html