Re: [EGIT PATCH 05/10] Do not write to the reflog unless the refupdate logmessage is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



onsdag 03 juni 2009 17:41:29 skrev "Shawn O. Pearce" <spearce@xxxxxxxxxxx>:
> Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote:
> > Do not write to the reflog unless the refupdate logmessage is set
> 
> Why not?  What is the justification for this?  Isn't a reflog record
> still useful, at least to point out that something happened at this
> point in time, and here's the old/new values?

I need to do an update without logging to avoid a "dummy" entry in the
reflog since I use the RefUpdate mechanism. Since this is an API and
not and end user function, I was thinking this might be ok after all.

Some other optione are:
1) set a special flag.
2) set a default message and allow the caller to set it to null and
not write if null. Today the default message is null leading to the
message "null" in the log, which is kind of ugly so we should
probably change this in any case.

-- robin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]