Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Change adding project to params if $params{"project"} is false
> to adding project to params if it not exist. It allows for href()
> to be used for projectless links by using "project=>undef" as
> argument, while still adding project to params by default
> in the most common case.
This did not parse very well, at least for me.
> @@ -1304,9 +1305,11 @@ sub git_footer_html {
> if (defined $descr) {
> print "<div class=\"page_footer_text\">" . esc_html($descr) . "</div>\n";
> }
> - print $cgi->a({-href => href(action=>"rss"), -class => "rss_logo"}, "RSS") . "\n";
> + print $cgi->a({-href => href(action=>"rss"),
> + -class => "rss_logo"}, "RSS") . "\n";
> } else {
> - print $cgi->a({-href => href(action=>"opml"), -class => "rss_logo"}, "OPML") . "\n";
> + print $cgi->a({-href => href(project=>undef, action=>"opml"),
> + -class => "rss_logo"}, "OPML") . "\n";
> }
> print "</div>\n" .
> "</body>\n" .
Argh. While I very much welcome folding of the long lines, I'd
rather see a separate patch to clean up other loooooooong lines
the current gitweb code has.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html