Hi, On Sat, Jun 6, 2009 at 4:46 AM, Jakub Narebski<jnareb@xxxxxxxxx> wrote: >> From: Mike Hommey <mh@xxxxxxxxxxxx> >> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl() > > So what is the title of this patch? "transport.c::get_refs_via_curl(): > do not leak refs_url" or "Some cleanup in get_refs_via_curl()"? See my reply to patch #19. > Perhaps it should be "transport.c: Do not leak refs_url in > get_refs_via_curl()"...? I think it's a matter of preference. I'll put them side-by-side to demonstrate this better: transport.c: Do not leak refs_url in get_refs_via_curl() transport.c::get_refs_via_curl(): do not leak refs_url There isn't any important difference between the two other than form. -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html