On Fri, 5 Jun 2009, Shawn O. Pearce wrote:
> Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> >
> > Here we were talking about the following part of exchange:
> > (I have added "C:" prefix to signal that this is what client,
> > git-clone here, sends; I have added also explicit "\n" to mark LF
> > characters terminating lines, and put each pkt-line on separate line)
> >
> > gb> C: 0054want 74730d410fcb6603ace96f1dc55ea6196122532d multi_ack side-band-64k ofs-delta\n
> > gb> C: 0032want 7d1665144a3a975c05f1f43902ddaf084e784dbe\n
> > gb> C: 0032want 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a\n
> > gb> C: 0032want 7e47fe2bd8d01d481f44d7af0531bd93d3b21c01\n
> > gb> C: 0032want 74730d410fcb6603ace96f1dc55ea6196122532d\n
> > gb> C: 0000
> > gb> C: 0009done\n
> >
> > and where server response is (again the quote from "Git Community Book"
> > was modified, removing here doublequotes and doubling of backslashes):
>
> That should be fine.
>
> Here's a dummy client that works against both jgit and C Git:
>
> perl -e '
> $h="fcfcfb1fd94829c1a1704f894fc111d14770d34e";
> $c="multi_ack side-band-64k ofs-delta";
> sub w{$_=shift;printf "%4.4x%s",4+length,$_;}
> w("git-upload-pack /.git");
> w("want $h $c\n");
> printf "0000";
> w("done")
> ' | nc localhost 9418
>
> Are you sure you are flushing the IO buffers in the dummy client?
That is not what I meant. Perhaps I didn't explain it clear enough...
The above sequence works fine with dummy client in Perl; where it hangs
is when client tries to wait for server response (NAK or ACK) _before_
sending "done":
$sock->print(pkt_line("want $h $c\n"));
$sock->print("0000");
$sock->flush();
while (!$sock->eof()) {
my $r = $sock->read($hex4, 4);
...
}
$sock->print("0009done\n");
$sock->flush();
But perhaps I did something wrong in my dummy client...
Also the flush "0000" seems to be required... but when I tried to repeat
it using the above example it actually does not hang, but doesn't get
PACK from git-daemon: there is something wrong in above snippet, as
I get the same error on server whether I put "0000" flush line or not...
c$ perl -e '
my $h="c1e54552c9b35521f189db53db24cc82b5b75816";
my $c="multi_ack side-band-64k ofs-delta";
sub w{$_=shift;printf "%04x%s",4+length,$_;}
w("git-upload-pack /git.git");
w("want $h $c\n");
## printf "0000"; # <-- commented out!
w("done");
' | nc localhost -v 9418
s$ git daemon --export-all --verbose \
--base-path=/home/local/scm/ /home/local/scm/
[12791] Connection from 127.0.0.1:42484
[12791] Request upload-pack for '/git.git'
fatal: git upload-pack: not our ref c1e54552c9b35521f189db53db24cc82b5b75816 multi_ack side-band-64k ofs-delta
[12692] [12791] Disconnected (with error)
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html