Jeff King <peff@xxxxxxxx> writes: > Should we be calling malloc here? One of the possible error conditions > is that we're out of memory (though xmalloc itself just uses "die"). I > don't think there is a good reason not to use a reasonably-sized static > buffer, which should increase robustness (report() is already using a > 1024-character buffer, so any message would be truncated there anyway). Yup, and at that point, tacking strerror value while expanding possible % becomes even easier. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html