Hi, On Mon, 1 Jun 2009, Junio C Hamano wrote: > Steffen Prohaska <prohaska@xxxxxx> writes: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > Windows has problems changing the mtime when the file is write protected, > > even by the owner of said file. > > > > Add a Windows-only workaround to change the mode if necessary before > > trying to change the mtime. > > I'll queue this as-is for now, but shouldn't the code remember the > original mode and change it back? Hmm, good point. As I mentioned in another mail, though, I cannot access any Windows machine to fix this issue now, sorry. Not changing the mode back _might_ paper over another issue: if the files are deleted later, that mode change might mean that the deletion now succeeds, and fixing test-chmtime may make it fail again. Not sure, though. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html