Re: [PATCH 15/18] http*: add http_get_info_packs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, May 25, 2009 at 4:43 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> It makes me wonder if fetch_index(), even though it is static to http.c,
> should be renamed somehow to reduce confusion between it and
> fetch_http_pack_index().

Indeed. What I'm now doing is

fetch_index --> fetch_pack_index
setup_index --> fetch_and_setup_pack_index

> You have decl-after-statement and a handful of variable that are no longer
> used.  Please squash this in when rerolling.
>
>  http-push.c   |    2 --
>  http-walker.c |    1 -
>  http.c        |   10 +++-------
>  3 files changed, 3 insertions(+), 10 deletions(-)

Thanks for including a patch.

-- 
Cheers,
Ray Chuan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]