Re: [PATCH 07/18] Some cleanup in get_refs_via_curl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tay Ray Chuan <rctay89@xxxxxxxxx> writes:

> Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx>
> Signed-off-by: Tay Ray Chuan <rctay89@xxxxxxxxx>

The same comment as 06/18 on attribution apllies.

Be specific when you can without going to too verbose.  In this case,
instead of wasting two meaningless words "Some cleanup", you can say:

	Subject: transport.c::get_refs_via_curl(): do not leak refs_url

>  transport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/transport.c b/transport.c
> index 89d846e..b7c1c39 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
>  		free(ref);
>  	}
>
> +	free(refs_url);
>  	return refs;
>  }
>
> --
> 1.6.3.1
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]